Modifies Keyboard events to use the code property
#772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the `code` property on the `KeyboardEvent`
**This is a breaking change** Fixes #766 by adding a new `KeyCode` enum, which is populated with the values from the `code` property of the KeyboardEvent. Additionally, the `Key` class also has a new `location` property, which maps to the `location` property of the KeyboardEvent. The KeyboardEvent itself now also supports some new additional properties: * `isRepeat` - a boolean indicating if the key is being held down * `isCtrlKey` - a boolean indicating if the Ctrl key is pressed * `isMetaKey` - a boolean indicating if the Meta key is pressed * `isAltKey` - a boolean indicating if the Alt key is pressed * `isShiftKey` - a boolean indicating if the Shift key is pressed
…thods to Keyboard to check for key codes in keysUp and keysDown
Also improves equality checks and adds unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change
Fixes #766 by adding a new
KeyCodeenum, which is populated with the values from thecodeproperty of the KeyboardEvent. Additionally, theKeyclass also has a newlocationproperty, which maps to thelocationproperty of the KeyboardEvent.All
Key.*_ARROWconstants are nowKey.ARROW_*to bring it in line with the key codes that they relate to:Key.UP_ARROWis nowKey.ARROW_UPKey.DOWN_ARROWis nowKey.ARROW_DOWNKey.LEFT_ARROWis nowKey.ARROW_LEFTKey.RIGHT_ARROWis nowKey.ARROW_RIGHTThe KeyboardEvent itself now also supports some new additional properties:
isRepeat- a boolean indicating if the key is being held downisCtrlKeyDown- a boolean indicating if the Ctrl key is pressedisMetaKeyDown- a boolean indicating if the Meta key is pressedisAltKeyDown- a boolean indicating if the Alt key is pressedisShiftKeyDown- a boolean indicating if the Shift key is pressedAdditionally adds
isNumericandasNumericmethods toKeyin order to fulfill #746