Add IsAdmin & IsAuthor checks #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asyasky
force-pushed
the
PolicyBasedRoles
branch
from
d460d9d
to
ca6ecd6
Compare
tabascq
approved these changes
Nov 8, 2018
| @@ -11,7 +11,7 @@ public class EventAdmins | |||
| /// Foreign key - event table | |||
| /// </summary | |||
| [ForeignKey("Event.ID")] | |||
| public virtual EventOwners Event { get; set; } | |||
| public virtual Event Event { get; set; } | |||
morganbr
reviewed
Nov 8, 2018
Data/DataModel/PuzzleUser.cs
Outdated
| /// </summary> | ||
| /// <param name="thisEvent">The event that's being checked</param> | ||
| /// <param name="puzzleServerContext">Current PuzzleServerContext</param> | ||
| public List<Puzzle> GetPuzzlesForAuthorAndEvent(PuzzleServerContext dbContext, Event thisEvent) |
There was a problem hiding this comment.
Why would this be in this class (or this change?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checked to unblock progress on author & admin filtering. This check will be replaced by a site wide policy soon (but use these methods in the meantime and I'll take on the cleanup that results).