Azure deployment glue #118
Conversation
| @@ -0,0 +1,33 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
You seem to have two of these. Do we actually need both?
There was a problem hiding this comment.
Nope, good catch, thanks! :)
| } | ||
| }, | ||
| "ServerCore": { | ||
| "commandName": "Project", | ||
| "launchBrowser": true, | ||
| "environmentVariables": { | ||
| "ASPNETCORE_ENVIRONMENT": "Development" | ||
| "ASPNETCORE_ENVIRONMENT": "Development", |
There was a problem hiding this comment.
Do you need to leave this on for now? If so, please file an issue to turn it off
There was a problem hiding this comment.
This is the only way to get useful error messages right now. I'm looking into other ways for the long term (supposedly I can turn on logging in the web.config, but the web.config is generated during Publish & I haven't traced that back to what I actually need to do). I'll add an issue.
ServerCore/Startup.cs
Outdated
| @@ -14,6 +15,17 @@ public Startup(IConfiguration configuration) | |||
| Configuration = configuration; | |||
| } | |||
|
|
|||
|
|
|||
| services.AddDbContext<PuzzleServerContext> | ||
| (options => options.UseLazyLoadingProxies() | ||
| .UseSqlServer(Configuration.GetConnectionString("PuzzleServerContext"))); | ||
| // Use SQL Database if in Azure, otherwise, use localdb |
There was a problem hiding this comment.
This looks like duplication of Program.cs. Which one do we actually need?
| @@ -14,6 +15,17 @@ public Startup(IConfiguration configuration) | |||
| Configuration = configuration; | |||
| } | |||
|
|
|||
|
|
|||
| public Startup(IHostingEnvironment env) | |||
There was a problem hiding this comment.
Also looks like a dupe of Program.cs
ServerCore/Startup.cs
Outdated
| } | ||
| else | ||
| { | ||
| app.UseDeveloperExceptionPage(); |
There was a problem hiding this comment.
Please remove this or file an issue to do so
There was a problem hiding this comment.
Removed (was for debugging)
| }); | ||
| } | ||
|
|
||
| // This method gets called by the runtime. Use this method to configure the HTTP request pipeline. | ||
| public void Configure(IApplicationBuilder app, IHostingEnvironment env) | ||
| { | ||
| if (env.IsDevelopment()) | ||
| PuzzleServerContext.UpdateDatabase(app); |
There was a problem hiding this comment.
Is this how we actually want production db updates to happen?
There was a problem hiding this comment.
That is an excellent question and I don't have an answer right now. This is the simplest way to take care of the database, but it does prevent us from having full control once we have real data.
|
|
||
| services.AddDbContext<PuzzleServerContext> | ||
| (options => options.UseLazyLoadingProxies() | ||
| .UseSqlServer(context.Configuration.GetConnectionString("PuzzleServerSQLConnectionString"))); |
There was a problem hiding this comment.
Please document where our secrets are and how to set them up as part of this so we can set up real production if we need it
There was a problem hiding this comment.
The secrets store isn't set up yet, right now we're using the Azure Application Settings - a future change will turn on KeyVault access and I'll add docs for using that.
* Adds logic required to deploy to Azure using Continuous Deployment. * Yaml updates
* Adds logic required to deploy to Azure using Continuous Deployment. * Yaml updates
* Adds logic required to deploy to Azure using Continuous Deployment. * Yaml updates
* Adds logic required to deploy to Azure using Continuous Deployment. * Yaml updates
* Adds logic required to deploy to Azure using Continuous Deployment. * Yaml updates
Adds/updates the things we need to do an Azure Deployment using Azure DevOps Continuous Deployment. Sets up the framework for using Storage & KeyVault.