Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role-switching & improved page-to-page navigation #161

Merged
merged 24 commits into from
Jan 15, 2019

Conversation

jenetlan
Copy link
Contributor

No description provided.

Updates to remove create new for authors and show it on the 'no team' page for players if the event is open for registration
Updates to remove create new for authors and show it on the 'no team' page for players if the event is open for registration
Added empty file for EventHome
…ed destinations elsewhere (where routing is required)
Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving for expediency's sake, since I don't think there's anything structurally wrong with the approach and I think it's hard to fully review without being able to see it in action.

It'll be nice to have this in place!

ServerCore/Pages/EventSpecific/FAQ.cshtml Show resolved Hide resolved
@model ServerCore.Pages.EventSpecific.IndexModel
@{
ViewData["Title"] = Model.Event.Name;
ViewData["AdminRoute"] = "/EventSpecific/Index";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the absence of the data means go to the index? You'd have fewer records that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in remove the word "Index" or as in remove this line entirely since it is the default? I included the line so that I wouldn't think I had forgotten to add an admin route and to keep this consistent in case the default changes, but I could clean up the word "Index"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in separate cleanup if needed

ServerCore/Pages/Hints/Create.cshtml Show resolved Hide resolved
ServerCore/Pages/Shared/_Layout.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Shared/_Layout.cshtml Show resolved Hide resolved
ServerCore/Pages/Submissions/Index.cshtml.cs Show resolved Hide resolved
@@ -43,4 +43,15 @@
<ItemGroup>
<WCFMetadata Include="Connected Services" />
</ItemGroup>
<ItemGroup>
<Content Update="Pages\EventSpecific\FAQ.cshtml">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with these? Most pages don't need this sort of thing. Are you sure it's necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd - I don't think I touched those. It might have been something automatic?

@jenetlan jenetlan merged commit 1970334 into PuzzleServer:master Jan 15, 2019
@jenetlan jenetlan deleted the TeamAuth branch January 15, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants