-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback pages improvements #183
Conversation
sprx97
commented
Jan 17, 2019
- If a user has already submitted feedback it will seed the page with what they submitted last time.
- When they resubmit it will update instead of duplicating.
- Shows user that submitted each piece of feedback in author view
- Aggregates all feedback in author view
- If a user has already submitted feedback it will seed the page with what they submitted last time. - When they resubmit it will update instead of duplicating. - Shows user that submitted each piece of feedback in author view - Aggregates all feedback in author view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm going to be hard to find for a few days, I'm not going to either approve or request changes. My only question is whether the change to Feedback.cs breaks the database and requires a migration. If you already discussed this with @morganbr I trust whatever he told you, if not then I hope he'll ring in here.
@PuzzleServer/adminteam Can someone take a look at this so its ready for checkin after I demo tomorrow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll still need to check with Morgan or Megan about the DB migration unfortunately - my guess would be yes but maybe it works because the data type is the same or the user ids happen to match? Hopefully you can do that at the start of the meeting so you can check it in right away. Otherwise a few code organization things - this looks awesome :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!