Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback pages improvements #183

Merged
merged 4 commits into from
Jan 24, 2019
Merged

Feedback pages improvements #183

merged 4 commits into from
Jan 24, 2019

Conversation

sprx97
Copy link
Contributor

@sprx97 sprx97 commented Jan 17, 2019

  • If a user has already submitted feedback it will seed the page with what they submitted last time.
  • When they resubmit it will update instead of duplicating.
  • Shows user that submitted each piece of feedback in author view
  • Aggregates all feedback in author view

- If a user has already submitted feedback it will seed the page with what they submitted last time.
- When they resubmit it will update instead of duplicating.
- Shows user that submitted each piece of feedback in author view
- Aggregates all feedback in author view
Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm going to be hard to find for a few days, I'm not going to either approve or request changes. My only question is whether the change to Feedback.cs breaks the database and requires a migration. If you already discussed this with @morganbr I trust whatever he told you, if not then I hope he'll ring in here.

ServerCore/DataModel/Feedback.cs Show resolved Hide resolved
@sprx97
Copy link
Contributor Author

sprx97 commented Jan 22, 2019

@PuzzleServer/adminteam Can someone take a look at this so its ready for checkin after I demo tomorrow?

Copy link
Contributor

@jenetlan jenetlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll still need to check with Morgan or Megan about the DB migration unfortunately - my guess would be yes but maybe it works because the data type is the same or the user ids happen to match? Hopefully you can do that at the start of the meeting so you can check it in right away. Otherwise a few code organization things - this looks awesome :D

ServerCore/Pages/Puzzles/Feedback.cshtml Show resolved Hide resolved
ServerCore/Pages/Puzzles/Feedback.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Puzzles/SubmitFeedback.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Puzzles/SubmitFeedback.cshtml.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@jenetlan jenetlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@jenetlan jenetlan merged commit 0a0cd85 into PuzzleServer:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants