Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home FAQ Rules! #223

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Conversation

tabascq
Copy link
Contributor

@tabascq tabascq commented Jan 26, 2019

Adding a default homepagq, FAQ, and rules, as well as a PH20-specific set. The specific set of pages to use is controlled by a new HomePartial property on Event, so we can easily point all betas at the same content and easily add new content.

Adding a default homepagq, FAQ, and rules, as well as a PH20-specific set. The specific set of pages to use is controlled by a new HomePartial property on Event, so we can easily point all betas at the same content and easily add new content.
@@ -0,0 +1,98 @@
<div class="container">
<h1>FAQ</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume that you copied this from somewhere and not review the actual text. If you'd like me to actually review the content lmk

@@ -0,0 +1,3 @@
<div class="container">
<h2>Default FAQ!</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow....you take the bunnies out of this and then have the audacity to request a review....

...thankfully you have so much goodwill stocked up from making the demo event rabbit-themed that I can let this slide :P

/// <summary>
/// The prefix of the partial files that provide the Home, FAQ, and Rules content.
/// </summary>
public string HomePartial { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example of how this would look? I'm not really sure how I would reference this in an event - an example string might help (maybe as a comment?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example is "PH20" - that's why there's a PH20 folder with Home/FAQ/Rules stuff in it. We can have both the live event and the beta point at the same content.

@tabascq tabascq merged commit dd527cf into PuzzleServer:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants