Demo Fixes - #123, #168 #234
Conversation
Putting the whole demo in a transaction and also letting you immediately put yourself on a team to save time.
|
|
||
| await _context.SaveChangesAsync(); | ||
|
|
||
| if (teamLoneWolf != null) |
There was a problem hiding this comment.
Is there a reason this isn't just part of the if statement on line 225? Seems like it could be done there - not sure what I'm missing
There was a problem hiding this comment.
It needs to be somewhere after a SaveChangesAsync() in order to be valid - that's what gets the team ID set up.
| <div class="form-group"> | ||
| <div class="checkbox"> | ||
| <label> | ||
| <input asp-for="AddCreatorToLoneWolfTeam" /> @Html.DisplayNameFor(model => model.AddCreatorToLoneWolfTeam) |
There was a problem hiding this comment.
Do you know what this defaults to? It would be nice if we could default to yes since I'm guessing the common test case is to check on puzzles from a player's perspective rather than to test team registration from a player's perspective
There was a problem hiding this comment.
So far it's defaulting to false just like the "start the event" checkbox. Can turn these to true later if the group prefers.
Putting the whole demo in a transaction and also letting you immediately put yourself on a team to save time.