Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team registration improvements #323

Merged
merged 11 commits into from
Mar 21, 2019

Conversation

jenetlan
Copy link
Contributor

Changes to improve team registration ahead of opening PH20 team registration.

Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - most of my comments are nits, the only one I really am waiting on is the one in TeamListBase.

ServerCore/Pages/Teams/Delete.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Teams/List.cshtml Show resolved Hide resolved
ServerCore/Pages/Teams/Index.cshtml.cs Outdated Show resolved Hide resolved
ServerCore/Pages/Teams/TeamListBase.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One nit reported. Thanks!

@jenetlan jenetlan merged commit 38087a0 into PuzzleServer:master Mar 21, 2019
@jenetlan jenetlan deleted the Team_QoL_improvements branch April 25, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants