During the beta, once a puzzle is solved, all other hints become free. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabascq
approved these changes
Apr 9, 2019
| @@ -15,6 +15,8 @@ namespace ServerCore.Pages.Teams | |||
| [Authorize(Policy = "PlayerIsOnTeam")] | |||
| public class HintsModel : EventSpecificPageModel | |||
| { | |||
| private static bool IsBeta = true; // TODO: I don't know how to tell if this is a beta; this code seems not to have the event object available | |||
There was a problem hiding this comment.
EventSpecificPageModel has an Event property on it. I think you can use Event.Name.Contains("Beta") like you wanted.
|
Thanks! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have time to finish testing this now but I have a question so I figure I'd go ahead and upload it and ask. It looks like there is no concept of beta in the app right now. I thought I could check the event name and if it has 'beta' in it, it's a beta. But Hints has no access to the event object. (I think it doesn't actually need it because all the puzzle ids and team ids are unique across all events. Is that right?)
So what I did instead was hardcode
IsBeta = trueand then we would need to redeploy later with that flag set false. Any better ideas?