Jessica/new errata #396
Merged
Jessica/new errata #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with upstream master Please enter a commit message to explain why this merge is necessary,
tabascq
reviewed
Apr 18, 2019
There was a problem hiding this comment.
I approve this change in theory, BUT I do not want us to take it before we are sure we have bandwidth for a database deployment, and I also do not want it to be accidentally merged without the database deployment. Accordingly I am not actually changing the state to Approved. @asyasky , if you feel like doing a database deployment before PH20, you could take this, but we're completely fine with mitigating PH20 risk and simply waiting for Puzzleday.
tabascq
approved these changes
Apr 25, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#316
Create Errata page