Local Time Zone (fixes #102) #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All times displayed in the UX for players, authors, and admins now appear in the browser's local time zone, with the exception of the event creation/properties because I don't know how to do the time zone transitions for editable fields. Internet wisdom is that the only way to do this well is to do it in Javascript because anything done on the server will use the server timezone instead of the user timezone. I searched around for a while to locate the easiest-looking version of this, and it seems to be working properly.
tabascq
requested review from
sprx97,
digit01Wave,
lambertwang-zz,
morganbr and
jenetlan
jenetlan
reviewed
Apr 25, 2019
ServerCore/Pages/Teams/Status.cshtml
Outdated
| @@ -65,7 +65,7 @@ | |||
| } | |||
| else | |||
| { | |||
| @Html.DisplayFor(modelItem => item.SolvedTime) | |||
| <time>@item.UnlockedTime.Value.ToString("yyyy-MM-ddTHH:mm:ssZ")</time> | |||
There was a problem hiding this comment.
Should be item.SolvedTime?
| @@ -43,7 +43,7 @@ | |||
| { | |||
| <tr> | |||
| <td> | |||
| @item.TimeSubmitted | |||
| <time>@item.TimeSubmitted.ToString("yyyy-MM-ddTHH:mm:ssZ")</time> | |||
There was a problem hiding this comment.
Any chance the format string could be part of the function so we don't have a copy-pasted string in quite so many places?
| @@ -77,7 +77,7 @@ | |||
| @Html.DisplayFor(modelItem => item.Hint.Cost) | |||
| </td> | |||
| <td> | |||
| @Html.DisplayFor(modelItem => item.UnlockTime) | |||
| <time>@item.UnlockTime?.ToString("yyyy-MM-ddTHH:mm:ssZ")</time> | |||
There was a problem hiding this comment.
Is there a reason this is the only one with a null check?
jenetlan
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All times displayed in the UX for players, authors, and admins now appear in the browser's local time zone, with the exception of the event creation/properties because I don't know how to do the time zone transitions for editable fields.
Internet wisdom is that the only way to do this well is to do it in Javascript because anything done on the server will use the server timezone instead of the user timezone. I searched around for a while to locate the easiest-looking version of this, and it seems to be working properly.