Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Mailer #406

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Bulk Mailer #406

merged 4 commits into from
Apr 25, 2019

Conversation

tabascq
Copy link
Contributor

@tabascq tabascq commented Apr 22, 2019

Add a bulk mailer for all players and for all team primary contacts. Currently the mailer is under strict admin control in order to make sure that we have a coordinated sender who knows about our monthly limits.

Add a bulk mailer for all players and for all team primary contacts. Currently the mailer is under strict admin control in order to make sure that we have a coordinated sender who knows about our monthly limits.
@tabascq tabascq requested review from Vroo and jenetlan April 22, 2019 02:51
Copy link
Contributor

@morganbr morganbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please find a reason to email all players before the event so we can make sure this page doesn't time out under large numbers.

break;
}

MailHelper.Singleton.SendPlaintextBcc(addresses, MailSubject, MailBody);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If addresses is empty, we probably shouldn't try to send

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to worry about this edge case right now, it's not going to happen in practice for PH20

break;
}

MailHelper.Singleton.SendPlaintextBcc(addresses, MailSubject, MailBody);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we end up with an async version of sending mail? If so, it's probably better to use it for large batches

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MailHelper calls SendMailAsync() and does not await the result.


switch(Group)
{
case MailGroup.AllPlayers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we also need a way to email small teams since we have a lot of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the ability to mail a team.


switch(Group)
{
case MailGroup.AllPlayers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PuzzleDay we may need to email individual teams (e.g. "Go to the live event that you forgot"). I can't immediately think of a case for Hunt though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the ability to mail a team.

@jenetlan jenetlan merged commit 766be8c into PuzzleServer:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants