Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event pages #44

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

tabascq
Copy link
Contributor

@tabascq tabascq commented Aug 27, 2018

#19

@@ -0,0 +1,59 @@
using System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to allow event deletion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came for free from the wizard - willing to delete later.

<thead>
<tr>
<th>
@Html.DisplayNameFor(model => model.Event[0].Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if there are no events?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's exactly the same code as the wizard generated for Index.cshtml for Puzzles, and that works. Agree it smells funky though.

@Html.DisplayNameFor(model => model.Event[0].TeamRegistrationEnd)
</th>
<th>
@Html.DisplayNameFor(model => model.Event[0].TeamNameChangeEnd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have the set of begin/end times we actually want? Do "team name change", "standings available begin", "team delete end" all matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I've thought about it. I am more creating this so we can start assigning puzzles to events and making multiple events.

@tabascq tabascq merged commit 76de0c8 into PuzzleServer:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants