Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Empty Swag #479

Merged
merged 2 commits into from
May 30, 2019
Merged

Conversation

tabascq
Copy link
Contributor

@tabascq tabascq commented May 30, 2019

Make sure that players who have not selected any swag show up, so we know who to check up on.

Make sure that players who have not selected any swag show up, so we know who to check up on.
@tabascq tabascq requested review from morganbr and jenetlan May 30, 2019 03:25
PlayerName = t.Member.Name,
TeamName = t.Team.Name,
Lunch = swagState == null ? null : swagState.Lunch,
LunchModifications = swagState == null ? null : swagState.LunchModifications,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could optionally be shortened to LunchModifications = swagState?.LunchModifications,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - you can't use the ?. operator here, the compiler complains. Ask me how I know :-)

@tabascq tabascq requested a review from morganbr May 30, 2019 03:39
@tabascq tabascq merged commit c33ab8d into PuzzleServer:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants