Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DB Change] Add DC property to puzzles & remove puzzle details page #480

Merged
merged 29 commits into from
May 30, 2019

Conversation

jenetlan
Copy link
Contributor

Adding a data confirmation (DC) property to puzzles. In the future this can help us mark puzzles with DC on the list page and possibly include the DC icon on the submissions page, as well as allowing us to potentially adjust the lockout algorithm for DC puzzles.

Also removed the puzzle details page and redirected incoming links to the edit page instead. The details page was very far behind the properties that puzzles support and was just an extra step in getting to the useful info about each puzzle.

@jenetlan jenetlan changed the title [DB change] Add DC property to puzzles & remove puzzle details page [DB Change] Add DC property to puzzles & remove puzzle details page May 30, 2019
/// <summary>
/// True if this puzzle has data confirmation
/// </summary>
public bool HasDataConfirmation { get; set; } = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initializing to false is redundant

@@ -0,0 +1,23 @@
using Microsoft.EntityFrameworkCore.Migrations;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to merge between this migration and #478

@jenetlan jenetlan merged commit e04b591 into PuzzleServer:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants