Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team composition #494

Merged
merged 4 commits into from
Jun 22, 2019
Merged

Conversation

digit01Wave
Copy link
Contributor

#22
Team member composition report

Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would benefit slightly by sorting the list but overall looks good!

<a asp-page="/Teams/TeamCompositionSummary">Team Composition</a> @("|")
@if (Model.Event.IsInternEvent)
{
<a asp-page="/Swag/Report">Intern T-shirts and Lunch</a> @("|")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides the swag report from authors. I think they might need access to it.

{
public TeamComposition(int teamId)
{
this.TeamID = teamId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this. required

@tabascq tabascq merged commit a988c0d into PuzzleServer:master Jun 22, 2019
@digit01Wave digit01Wave deleted the jessica/TeamComposition branch March 26, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants