Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow postgame #543

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Allow postgame #543

merged 3 commits into from
Jul 11, 2019

Conversation

morganbr
Copy link
Contributor

@morganbr morganbr commented Jul 9, 2019

Allow submissions after the event is over without affecting the results

@morganbr
Copy link
Contributor Author

morganbr commented Jul 9, 2019

Nate suggested adding the same banner to the puzzle list

tabascq
tabascq approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is all interesting stuff, but before checking it in I'd like to have a discussion tomorrow evening. It does seem a little odd to allow submissions while answers are posted...

@morganbr
Copy link
Contributor Author

Live comments:

  • Use warning color
  • Make size match "oops" warning
  • Add warning to play page
  • Add box to puzzles solved after the event saying it didn't count

jenetlan
jenetlan requested changes Jul 11, 2019
View reviewed changes
ServerCore/Pages/Teams/Play.cshtml Outdated Show resolved Hide resolved
@morganbr morganbr merged commit d906cf7 into PuzzleServer:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenetlan jenetlan jenetlan approved these changes

@tabascq tabascq tabascq approved these changes

@digit01Wave digit01Wave Awaiting requested review from digit01Wave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganbr @jenetlan @tabascq