Block out Menus #56
Block out Menus #56
Conversation
Laying down some basic menu structure for inspiration. Open to change, just helping to define the rough shape of things.
tabascq
requested review from
metapzl,
asiacomeau,
morganbr,
jenetlan and
asyasky
…ering out menu items based on event state (active/over), but for now I am leaving everything in for clarity.
| </head> | ||
| <body> | ||
| @{ | ||
| var Event = ViewData["Event"] as ServerCore.DataModel.Event; |
There was a problem hiding this comment.
Is it necessary to use ViewData in layouts or is there some way to reference the model?
There was a problem hiding this comment.
The book I have says ViewData is needed for things in the shared file. With more engineering I am sure there is something more strongly typed but I am not sure it is worth it. I do have plans to automatically fill in the Event via routing and other things, which will help somewhat.
|
|
||
| @if (Event != null) | ||
| { | ||
| <li class="dropdown"> |
There was a problem hiding this comment.
Should we indent from the curly brace @asyasky?
There was a problem hiding this comment.
Yes please. :) An automatic style sheet is on my todo list, but in the mean time ctrl+k+d fixes up most things (not sure about cshtml, but it does in cs for sure).
|
Screenshots are a bit of a chore with dropdowns but in general I get your point :-) |
|
And thanks for the review! |
Laying down some basic menu structure for inspiration. Open to change,
just helping to define the rough shape of things.
Linked to Issue #53.