Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external authentication (MSA) and users #82

Merged
merged 5 commits into from
Nov 6, 2018

Conversation

asyasky
Copy link
Collaborator

@asyasky asyasky commented Oct 11, 2018

Allows profile creation and login using Microsoft Accounts.

#23

Copy link
Contributor

@tabascq tabascq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I felt qualified to review most of this, but thanks for getting it rolling. One thing I don't see in here is how you get to a PuzzleUser object - it may be in there but I don't know how to find it :-)

<hr />
<div class="row">
<div class="col-md-3">
<partial name="_ManageNav" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to make our menu into a partial like this (first I've heard of this feature, I assume this is an instruction to include _ManageNav.cshtml) and include it in this page.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good plan for standardizing across pages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's what _Layout.cshtml is as well

ServerCore/DataModel/User.cs Show resolved Hide resolved
ServerCore/Properties/launchSettings.json Show resolved Hide resolved
Copy link
Contributor

@morganbr morganbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay auth! This will be good once the additional cleanup is done or issues are filed.

Data/DataModel/PuzzleUser.cs Show resolved Hide resolved
public string EmployeeAlias { get; set; }
public string Name { get; set; }

[Display(Name = "T-shirt size")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be conditional on intern events or other event properties?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, maybe not - the user persists between events, it's not linked to events. The current site has this visible all the time.

@@ -0,0 +1,26 @@
Support for ASP.NET Core Identity was added to your project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to leave it in because there are things mentioned that don't seem to be documented other places (e.g. that order matters).

ServerCore/Pages/Shared/_CookieConsentPartial.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Shared/_CookieConsentPartial.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Shared/_CookieConsentPartial.cshtml Outdated Show resolved Hide resolved
ServerCore/Pages/Shared/_Layout.cshtml Outdated Show resolved Hide resolved
ServerCore/ServerCore.csproj Show resolved Hide resolved
Copy link
Contributor

@morganbr morganbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as you test the transaction and employee signin questions. Thanks for auth!

@asyasky asyasky merged commit 994590e into PuzzleServer:master Nov 6, 2018
@asyasky asyasky deleted the localAuthAndRoles branch November 6, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants