-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event customization #946
Event customization #946
Conversation
I think custom per-event CSS outside the repo is a great idea - but I also think it should be an event property, not a puzzle property, and apply to all pages rather than just puzzle pages. Thoughts? |
After discussion at the meeting, this looks like a great opportunity to go "yes, and". First, we need to really stop using the wwwroot folder, full stop. Now that we have the per-event puzzle-agnostic resource file repository from #936, everything to style the website should go in there. So, from this first commit, change the resource location from the wwwroot folder to the Azure storage Resources folder. That way, css file changes don't need an entire website redeploy! Second, we're going to change the structure of the other stuff that's required in order to deploy a new event. For example, #788 to add a new PD event needs new partial pages in Pages/Resources/. Those partials should be changed to just be a barebones wrapper that looks for a file with a specific name in the Azure storage Resources folder, and if not, shows an appropriate blank message. Currently, the wrapper looks for content in the event properties. Those properties can't be removed from the database, but we can remove them from the event management page so future events don't use them, and then we just look for a resource file instead. That way, changing site content no longer needs site deployment if you don't want to use the event properties, although like the event properties, we lose any asp benefits since we're using plain html. On the plus side, this also no longer requires us to remember to add the minified css building to bundleconfig.json either. Then, any other css files to style the entire event will also be uploaded to that Azure storage Resources folder (alongside the per-puzzle css files already envisioned here, the resource files that the puzzles themselves reference for styling (which could overlap with the files used by the host per-puzzle page), etc. That means that the following css file structure should be used moving forward (obviously this is just a recommendation, and naming could be improved):
Finally, the rest of the pages on the site should have
|
ServerCore/wwwroot/lib/jquery-validation-1.19.2-dist/jquery.validate.js
Outdated
Show resolved
Hide resolved
LGTM other than the one new comment, and also please merge with main and rebuild the migration part since Jessica's change also had migrations in it. |
Note: turn off whitespace differences to review this PR
Goal: support custom theming for an event that doesn't require re-deploying the website or changing any files in this repo.
Associated work items: #954, #913, Wiki page with how-to for creating future events
This PR does the following, in order of files changed:
home-content.html
,rules-content.html
, andfaq-content.html
files uploaded to the Shared Resources and shown in automatically-sized iframes, similar to embedded puzzles.global-styles.css
file from the Shared Resources, which is intended to be a companion to the puzzle-specific css files.-customizable
for targeted changes to things like puzzle titles that were previously pseudo-supported via Html.Raw, all of which are listed on the wiki. No css files in this repo use those classes for anything.Fixes the following bugs: