Feature: expose basic app options via CLI #48
Conversation
|
Side note to the maintainers - are you sure that https://github.com/apps/auto-assign is installed there? Minor thing but this PR didn't get the reviewers assigned automatically, I believe either the above should be installed or the yaml file should be extended to follow https://github.com/marketplace/actions/auto-assign-issue with |
| @@ -70,7 +66,7 @@ def create_json_book(self, input_book_path, password=None, extraction_engine=Non | |||
| ) | |||
|
|
|||
| if os.path.exists(os.path.join(BOOK_DIR, json_filename)): | |||
| metadata = {} | |||
| metadata = {"book_name": json_filename.split(".")[0]} | |||
There was a problem hiding this comment.
Missing book_name in metadata was triggering an exception when saving audio in case the json file already existed (with no book_name)
| else: | ||
| raise NotImplementedError("Only PDF, TXT, EPUB, MOBI, HTTP, DOCX and DOC files are supported") |
There was a problem hiding this comment.
Had to add an else condition to avoid errors saying that json_book and metadata are not always specified
| book_dir = os.path.join(BOOK_DIR, book_name) | ||
| os.makedirs(book_dir, exist_ok=True) | ||
|
|
||
| print("Saving audio files in folder: {}".format(book_name)) | ||
| print("Saving audio files in folder: {}".format(book_dir)) |
There was a problem hiding this comment.
Saving audio to the same directory that contains books makes more sense to me than the actual dir where the code lives
|
so that CLI will not affect the previous code(export as module). we can export it as a module as well. |
Pull Request Template
script name -
What have you Changed
Added CLI for basic usage of the app.
Issue no.(must) - #42
Self Check(Tick After Making pull Request)
If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS