pyupgrade: Modernize syntax for Python >= 3.7 #1080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaine
reviewed
Jan 23, 2023
| @@ -153,14 +153,14 @@ def inspect_member(node, name_prefix=''): | |||
| anchorfile = node.find('anchorfile').text | |||
| anchor = node.find('anchor').text | |||
|
|
|||
| url = '%s/%s#%s' % (doxygen_base, anchorfile, anchor) | |||
| url = '{}/{}#{}'.format(doxygen_base, anchorfile, anchor) | |||
jlaine
reviewed
Jan 23, 2023
|
|
||
| doxygen[name] = {'url': url} | ||
|
|
||
| if node.attrib['kind'] == 'function': | ||
| ret_type = node.find('type').text | ||
| arglist = node.find('arglist').text | ||
| sig = '%s %s%s' % (ret_type, name, arglist) | ||
| sig = '{} {}{}'.format(ret_type, name, arglist) |
|
I like:
The string formatting changes however are quite arbitrary and not even consistent. Sometimes f-string are used, sometimes not.. |
|
https://pypi.org/project/flynt will be more aggressive with f-string conversion while pyupgrade explains why it is intentionally timid https://github.com/asottile/pyupgrade#f-strings |
|
Should I run flynt also? |
|
I've cherry-picked the changes I'm comfortable with in #1202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyupgrade --py37-plus **/*.py