Fix running doctests #1199
Merged
Fix running doctests #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use `av.datasets` so explicitly import it
|
@WyattBlue it looks as though the changes for FFmpeg 6 dropped compatibility with FFmpeg < 5.0. This is fine by me but then let's make 5.0 our baseline including in docs: https://github.com/PyAV-Org/PyAV/blob/main/docs/overview/installation.rst?plain=1#L59 .. and the CI matrix. |
Our code now depends on FFmpeg 5.0 or better, so update the test matrix.
|
@jlaine I was just curious why have you decided to drop support for FFmpeg 4.x version, maybe at least support for 4.4 could be there for some more time |
|
@bedilbek We're dropping support for ffmpeg 5 full stop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
av.datasetsso explicitly import it