Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVFormat property start_time_realtime available in input container. #975

Closed
wants to merge 2 commits into from
Closed

Conversation

karoldob
Copy link

@karoldob karoldob commented Apr 26, 2022

start_time_realtime is useful if you want to synchronize multiple video streams.

@karoldob karoldob marked this pull request as ready for review April 26, 2022 14:26
@jlaine
Copy link
Member

jlaine commented Apr 26, 2022

Let's have a docstring + a unit test for this new property.

@karoldob
Copy link
Author

Sorry I had some issues with identites.
Docs, tests are ready

@karoldob karoldob reopened this Apr 26, 2022
@jlaine
Copy link
Member

jlaine commented Apr 27, 2022

Ouch I hadn't fully thought through my request for a unit test for this.. We already have a ticket complaining our test suite depends on network access, and this only makes this even more true!

@karoldob
Copy link
Author

karoldob commented Jul 12, 2022

Hi @jlaine all your suggestions are fixed. It looks label 'change requested` could be removed :)
Anything other blocks this merge?

@jlaine
Copy link
Member

jlaine commented Oct 17, 2022

@karoldob what was blocking was my lack of time :) I've rebased your code on top of master, with a slightly reworded docstring. Let's see how CI goes, I'm hoping to get this in for the next release which should be very soon.

@jlaine
Copy link
Member

jlaine commented Oct 17, 2022

Hm, it looks as though rtsp.stream is no longer available. That might be for the best, as increasing our dependency on "having network access" is not something I was looking forward to. I wonder if we can spin up our own RTSP server using PyAV?

@WyattBlue WyattBlue changed the base branch from main to wyattdummy November 25, 2023 07:46
@WyattBlue WyattBlue changed the base branch from wyattdummy to main November 25, 2023 07:47
@WyattBlue
Copy link
Member

This commit doesn't work anymore and don't care about this enough to fix it myself, so I will be closing.

@WyattBlue WyattBlue closed this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants