New sign tra

[HanslettTheDev]

Summary

This pull request aims to split the sign tra function based on this comment from @reingart.
Unit tests will also be added for all the functions to ensure they are properly tested and maintain the standards of the previous general function

Checklist

• Classes, Variables, function and methods logic ok
• Comments written explaining what the code does

[reingart]

Thank you @HanslettTheDev for the contribution!
I made some comments about styling and rewriting some conditions.
Don't forget to add the Unit Tests so this new functions could get coverage.

[reingart]

Hi @HanslettTheDev , the tests doesn't have any new UT (all changes are just whitespaces)

At least a test_sign_tra_openssl function should be added, that would work in any python / cryptography version.

For the old function version, you could just add a manual tests run evidence (running the python 2 virtualenv and attaching tests results)

TIP: use pytest coverage report:

pytest --cov-report term-missing --cov=pyafipws.wsaa tests/test_wsaa.py

Then you could see the report for wsaa.py file and confirm that the lines are being covered (exercised by the test):

---------- coverage: platform linux, python 3.10.6-final-0 -----------
Name      Stmts   Miss  Cover   Missing
---------------------------------------
wsaa.py     352     89    75%   58-65, 130, 177-199, 203-215, 227, 230-231, 274-276, 294, 323-325, 353-355, 380, 392, 406, 438, 445, 468, 474, 480-481, 485, 491-500, 513-533, 536-540, 552-561, 580-584, 613-614, 627-629, 635, 645
---------------------------------------
TOTAL       352     89    75%

[HanslettTheDev]

The unit testing functions are with me locally. I was working on a bunch of things so I will push all the commits today

[HanslettTheDev]

Manual test evidence of Pytest Test coverage on Python 2.7

[HanslettTheDev]

Coverage Report for both Python 2.7 and 3+

htmlcov-python3+.zip
htmlcov-python27.zip

[reingart]

Thanks for the coverage! the python2 zip seems to miss the wsaa.py html, could you re-upload or generate a new report?

[HanslettTheDev]

Reuploaded the test coverage report for python2.7
htmlcov-python27.zip