Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile command update for manual testing #126

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

HanslettTheDev
Copy link
Collaborator

Summary

My experience with testing pyafipws from the command line was a bit repetitive. So I decided to use a bunch of useful make commands that will reduce the workload of typing the commands over and over again. This PR solves the issue of repeatedly typing the same commands when running manual tests

Checklist

  • Classes, Variables, function and methods logic ok

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@HanslettTheDev HanslettTheDev added the enhancement New feature or request label Jul 17, 2023
Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HanslettTheDev for the contributions!

I made some comments to clarify the Makefile target and correct they names to avoid confusions.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make targets are inverted:

  • simple-invoice would be wsfev1
  • wsaa is access-ticket (sign-cert is also misleading, please rename it)

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@reingart reingart merged commit 6764931 into PyAr:main Aug 23, 2023
@HanslettTheDev HanslettTheDev deleted the new-makefile-commands branch August 23, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants