Create pyafipws installers and deploy as releases #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
reingart
force-pushed
the
create-release-py2exe
branch
from
0f82183 to
9053868
Compare
reingart
approved these changes
Aug 27, 2023
There was a problem hiding this comment.
Thanks @HanslettTheDev !
The changes seems ok to automate the installer generation, will merge to start testing the GitHub Action.
I've removed the VC redist binary to avoid problems in the repository (binary files should be uploaded with Git LFS).
Instead, it is now downloading the correct version for 32 or 64 bits of the vcredist.exe file.
That part could not be longer needed, and the NSIS script is checking for the 2008 redist version, but that could be revised in a new PR.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims to solve issue #109 and provide a GitHub action that will run every time there is a push on the main branch and generate a one-file installer and also make push a release containing the recent one-file installer
Initially, the workflow did not generate the exe file required, but it can now as it was missing a crucial file(vcredit_x86.exe). This has been tested locally. Currently the workflow deploys the installer as a release artifact
Checklist
Manual test evidence
Evidence of the generated exe file
