Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding unit tests for wsfev1 based on issue #107 #138

Merged
merged 2 commits into from
Nov 5, 2023
Merged

adding unit tests for wsfev1 based on issue #107 #138

merged 2 commits into from
Nov 5, 2023

Conversation

HanslettTheDev
Copy link
Collaborator

Summary

This PR aims to provide test coverage for some methods in the wsfev1.py file based on issue #107

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

(attach command-line examples, execution output & logs, etc.)

@HanslettTheDev
feat: adding unit tests for wsfev1 based on issue PyAr#107
171ad52 
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
reingart
reingart requested changes Oct 1, 2023
View reviewed changes
tests/test_wsfev1.py Outdated Show resolved Hide resolved
@HanslettTheDev
ref: refactored the function name, removed pytest.fixture
3a62832 
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
@reingart reingart merged commit aa7fd36 into PyAr:main Nov 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reingart reingart reingart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HanslettTheDev @reingart