Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added coverage #67

Merged
merged 3 commits into from
Jul 9, 2021
Merged

Added coverage #67

merged 3 commits into from
Jul 9, 2021

Conversation

chazuttu
Copy link
Collaborator

@chazuttu chazuttu commented Jul 1, 2021

Summary

This PR adds coverage support for the tests.

  • added coverage configuration file
  • updated requirements-dev.txt
  • updated python-package.yml file

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

chazuttu added 2 commits July 1, 2021 21:24
@chazuttu
updated workflow
d4f8b97 
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
@chazuttu
updated coverage config file and workflow
43fff42 
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
@chazuttu chazuttu requested a review from reingart July 1, 2021 17:37
reingart
reingart approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@reingart reingart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@reingart reingart merged commit fd14225 into PyAr:main Jul 9, 2021
@chazuttu chazuttu deleted the added_coverage branch July 26, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reingart reingart reingart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chazuttu @reingart