Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage pyqr #96

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Coverage pyqr #96

merged 7 commits into from
Aug 13, 2021

Conversation

chazuttu
Copy link
Collaborator

@chazuttu chazuttu commented Aug 9, 2021

Summary

This PR adds unit tests for the script pyqr.py and also increases its coverage.

  • added unit tests for pyqr.py
  • updated .coveragerc file
  • updated requirements-dev.txt file
  • added sample QR image for testing
  • increased code coverage upto 86% for pyqr.py

Checklist

  • Classes, Variables, function and methods logic ok
  • Comments written explaining what the code does
  • All python code is PEP8 compliant (run black .)
  • No lint issues (run flake8)
  • Test coverage with pytest implemented
  • Reviewers assigned (at least 1 mentor)

Manual test evidence

Python 3

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_pyqr.py

================= test session starts ========================
platform win32 -- Python 3.9.6, pytest-6.2.3, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\pyafipws, configfile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-3.1.1, metadata-1.11.0, mock-3.6.1, vcr-1.0.2
collected 6 items

tests\test_pyqr.py .....X                                                                                                                                                                                        [100%]


----------- coverage: platform win32, python 3.9.6-final-0 -----------
Name                                                                                       Stmts   Miss  Cover
--------------------------------------------------------------------------------------------------------------
test3\Lib\site-packages\PyAfipWs-3.9.b_2583_-py3.9.egg\pyafipws\__init__.py                    4      0   100%
test3\Lib\site-packages\PyAfipWs-3.9.b_2583_-py3.9.egg\pyafipws\pyqr.py                      104     15    86%
--------------------------------------------------------------------------------------------------------------

===================== 5 passed, 1 xpassed, 2 warnings in 4.24s ===============

Python 2

pytest --cov-config=.coveragerc --cov=pyafipws tests/test_pyqr.py

============================= test session starts =============================
platform win32 -- Python 2.7.18, pytest-4.6.11, py-1.10.0, pluggy-0.13.1
rootdir: C:\Users\pyafipws, inifile: pytest.ini
plugins: cov-2.12.1, freezegun-0.4.2, html-1.22.1, metadata-1.11.0, mock-2.0.0, vcr-1.0.2
collected 6 items

tests\test_pyqr.py .....x                                                [100%]

---------- coverage: platform win32, python 2.7.18-final-0 -----------
Name                                                                                    Stmts   Miss  Cover
-----------------------------------------------------------------------------------------------------------
test2\Lib\site-packages\PyAfipWs-2.7.2583-py2.7.egg\pyafipws\__init__.py                    4      0   100%
test2\Lib\site-packages\PyAfipWs-2.7.2583-py2.7.egg\pyafipws\pyqr.py                      104     15    86%
-----------------------------------------------------------------------------------------------------------


===================== 5 passed, 1 xfailed in 3.87 seconds =====================

Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
@chazuttu chazuttu requested a review from reingart August 9, 2021 20:51
Signed-off-by: UTKARSH KUMAR <Utkarshdhsbgp@gmail.com>
@reingart reingart merged commit 081a7e6 into PyAr:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants