Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore-path-errors does not work with a relative path #147

Closed
fmigneault opened this issue Aug 31, 2023 · 0 comments · Fixed by #148
Closed

ignore-path-errors does not work with a relative path #147

fmigneault opened this issue Aug 31, 2023 · 0 comments · Fixed by #148

Comments

@fmigneault
Copy link
Contributor

Given a project structure with:

<repo-root>
  docs
    changes.rst

where doc8 is executed from <repo-root>

Either using --ignore-path-errors "docs/changes.rst;D000" or setting ignore-path-errors = docs/changes.rst;D000, in the configuration file does not ignore the error.

Using the absolute file path, the error is properly ignored. However, this is not portable for any repository location.
fmigneault added a commit to Ouranosinc/Magpie that referenced this issue Aug 31, 2023
@fmigneault
tmp fix workaround (relates to PyCQA/doc8#145 and PyCQA/doc8#147)
102af33
fmigneault added a commit to fmigneault/doc8 that referenced this issue Sep 5, 2023
@fmigneault
fix absolute paths not considered for ignore-path-errors option (fixes …
708def1 
…PyCQA#147)
This was referenced Sep 5, 2023
Merged
Open
ssbarnea pushed a commit that referenced this issue Feb 15, 2024
@fmigneault
fix absolute paths not considered for ignore-path-errors option (#148)
84dc642 
fix absolute paths not considered for ignore-path-errors option (fixes #147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix absolute paths not considered for ignore-path-errors option fmigneault/doc8
1 participant
@fmigneault