Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pyproject.toml configuration #63

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Clarify pyproject.toml configuration #63

merged 2 commits into from
Sep 27, 2021

Conversation

felix-hilden
Copy link
Contributor

Hi, just for clarity I thought the pyproject configuration spec could be more verbose. This PR adds info on the assumed configuration section and the fact that the toml library needs to be installed.

Add info on the assumed configuration section and the fact that the `toml` library needs to be installed.
@felix-hilden felix-hilden requested a review from ssbarnea as a code owner August 10, 2021 11:46
@felix-hilden
Copy link
Contributor Author

Actually, it is common for tools to include an extra for installation, like pip install doc8[toml] for the optional dependency. Should that be added too?

@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Sep 27, 2021
@ssbarnea ssbarnea merged commit 6d93e18 into PyCQA:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants