-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B024: don't warn on classes without methods #336
Conversation
86ef281
to
36d815a
Compare
The error message in the readme and the message being raised were very different, so synced them to match better, and updated the message to be "softer". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @jakkdl!
cc @cooperlees in case you want to review, or plan a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to note the logic change / bug fix in the README?
36d815a
to
506f785
Compare
the error message, and changed the message in the README to match it better.
506f785
to
8116fdb
Compare
Fixed review comments and rebased on top of main |
Yup, much clearer. Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Fix another case in #278 - so now it won't warn on empty classes or any class without methods, esp since the fix proposed in the error message (consider adding
@abstractmethod
) is not useful in that case.@Zac-HD @mikhail-melnik