repair register opt calls #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake8 uses only argparse option styles now, use str instead of "string" for types given. Fixes: PyCQA#189
sqlalchemy-bot
pushed a commit
to sqlalchemy/sqlalchemy
that referenced
this pull request
Nov 23, 2022
…closed all comments, thank you! I'll get on that right away pyqca/flake8-import-order does not seem to have a release or a commit in the past two years, so while I have created an issue and PR [1] [2], for now vendor our fork so we can get on with things. Also fix one issue for flake8 6.0 [1] PyCQA/flake8-import-order#189 [2] PyCQA/flake8-import-order#190 Change-Id: I53045f65b8716cceaf2104fccc1d26f80b398fef References: PyCQA/flake8#1751
sqlalchemy-bot
pushed a commit
to sqlalchemy/sqlalchemy
that referenced
this pull request
Nov 23, 2022
…closed all comments, thank you! I'll get on that right away pyqca/flake8-import-order does not seem to have a release or a commit in the past two years, so while I have created an issue and PR [1] [2], for now vendor our fork so we can get on with things. Also fix one issue for flake8 6.0 [1] PyCQA/flake8-import-order#189 [2] PyCQA/flake8-import-order#190 Change-Id: I53045f65b8716cceaf2104fccc1d26f80b398fef References: PyCQA/flake8#1751 (cherry picked from commit fbec926)
alex
approved these changes
Nov 24, 2022
sigmavirus24
approved these changes
Nov 24, 2022
|
@pgjones if you'd add me to the PyPI page, I can try to put together a release with this fix |
|
Any idea when you will cut a new release? Thanks. |
|
Can't until I get release privileges |
This was referenced Nov 25, 2022
This comment was marked as abuse.
This comment was marked as abuse.
stephenworsley
pushed a commit
to SciTools/iris-esmf-regrid
that referenced
this pull request
Dec 6, 2022
* Unpin Flake8. * Update lockfiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 uses only argparse option styles now, use
str instead of "string" for types given.
Fixes: #189