-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid imports of collections.abc
aliases from typing
#213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Akuli
reviewed
Apr 18, 2022
AlexWaygood
commented
Apr 18, 2022
typeshed PR to add the required |
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 18, 2022
AlexWaygood
added a commit
to python/typeshed
that referenced
this pull request
Apr 18, 2022
Missed one.
JelleZijlstra
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 18, 2022
Missed one.
AlexWaygood
commented
Apr 18, 2022
Akuli
approved these changes
Apr 18, 2022
JelleZijlstra
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression test for python/typeshed#7635
Refs #46 (but doesn't quite close it).
Changes made
typing
that are aliases to objects incollections.abc
, except forAbstractSet
AbstractSet
fromtyping
collections.abc
are now preferred to imports fromtyping
.pyi.py
so as to quell flake8 from complaining that_check_import_or_attribute
was getting too complex.