Ban importing Match and Pattern from typing (import from re instead)
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AlexWaygood
added a commit
to python/typeshed
that referenced
this pull request
Jan 16, 2023
AlexWaygood
added a commit
to python/typeshed
that referenced
this pull request
Jan 16, 2023
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Jan 16, 2023
README.md
Outdated
| @@ -55,7 +55,7 @@ currently emitted: | |||
| | Y019 | Certain kinds of methods should use `_typeshed.Self` instead of defining custom `TypeVar`s for their return annotation. This check currently applies for instance methods that return `self`, class methods that return an instance of `cls`, and `__new__` methods. | |||
| | Y020 | Quoted annotations should never be used in stubs. | |||
| | Y021 | Docstrings should not be included in stubs. | |||
| | Y022 | Imports linting: use typing-module aliases to stdlib objects as little as possible (e.g. `builtins.list` over `typing.List`, `collections.Counter` over `typing.Counter`, etc.). | |||
| | Y022 | Use typing-module aliases to stdlib objects as little as possible (e.g. `builtins.list` over `typing.List`, `collections.OrderedDict` over `typing_extensions.OrderedDict`, etc.). | |||
There was a problem hiding this comment.
Why use typing_extensions here? I think typing is more "canonical", easier to understand, and more succinct.
There was a problem hiding this comment.
I realised we didn't mention anywhere that Y022 bans various imports from typing_extensions as well as various imports from typing, and that felt like something which might be useful to make clear. But I can reword this if the current phrasing is just confusing!
There was a problem hiding this comment.
How's it look now?
This comment has been minimized.
This comment has been minimized.
|
This change has no effect on typeshed. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46