-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify entry point naming #1646
Conversation
In the above, ``X`` is the entry point prefix and ``X101`` is the | ||
entry point name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so actually both X
and X101
are used as the entry point name (which is the prefix) -- the error code is X101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I wasn't fully understanding that still. I was looking at "ABC" and "123" as 2 different parts of the entry point name. I saw how the combination was the error code (or error code "prefix" in the case of something like X1 or just X). I added this to try to capture your comment about 3 letters being the max prefix length - I was trying to define what the "prefix" meant for an entry point. Would "In the above, you can think of the letters as a prefix to the entry point name." be better or maybe just leave those two lines out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the entry point is the prefix of the codes that the plugin produces -- I think that's the important part from this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - that's a much cleaner way to express it! I'll push an update that (hopefully) reflects that cleanly.
Clarified what is and is not a valid entry point name for registering plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your help and great comments/insights! I love the cat gif! |
heh -- I have a user script which auto-posts them https://www.youtube.com/watch?v=2rDNJvHznrM |
Clarified what is and is not a valid entry point name
for registering plugins.