Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git_hook() lazy option #1214

Closed
Dreamsorcerer opened this issue May 26, 2020 · 1 comment · Fixed by #1345
Closed

git_hook() lazy option #1214

Dreamsorcerer opened this issue May 26, 2020 · 1 comment · Fixed by #1345
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Dreamsorcerer
Copy link

Can we get a lazy option added, that matches flake8? i.e. It should include unstaged files if set to True.

https://gitlab.com/pycqa/flake8/-/blob/master/src/flake8/main/git.py#L22
@timothycrosley timothycrosley added enhancement New feature or request help wanted Extra attention is needed labels Jul 4, 2020
sztamas added a commit to sztamas/isort that referenced this issue Jul 25, 2020
@sztamas
Adds lazy option to git hook.
045c084 
Fixes PyCQA#1214
@sztamas sztamas mentioned this issue Jul 25, 2020
Merged
timothycrosley added a commit that referenced this issue Jul 25, 2020
@timothycrosley
Update changelog with fix for #1214
0fa0364
@timothycrosley
Copy link
Member

This was just deployed with version 5.2.0 of isort. Thanks!

~Timothy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds lazy option to git hook. sztamas/isort
2 participants
@timothycrosley @Dreamsorcerer