Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires appdirs >= 1.4.0 #907

Closed
edmondsw opened this issue Mar 21, 2019 · 1 comment
Closed

Requires appdirs >= 1.4.0 #907

edmondsw opened this issue Mar 21, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@edmondsw
Copy link

requirements.txt doesn't currently list a version of appdirs, meaning any version should work. But in fact if you try to use a version of appdirs < 1.4.0 you get AttributeError: module 'appdirs' has no attribute 'system'.
timothycrosley added a commit that referenced this issue Mar 24, 2019
@timothycrosley
Fix issue #907, adding minimal appdirs requirement version
9098463
@timothycrosley timothycrosley mentioned this issue Mar 24, 2019
Merged
@timothycrosley timothycrosley added the bug Something isn't working label Mar 24, 2019
timothycrosley added a commit that referenced this issue Mar 24, 2019
@timothycrosley
Merge pull request #912 from timothycrosley/feature/fix-issue-907
cd653c3 
Fix issue #907, adding minimal appdirs requirement version
@timothycrosley
Copy link
Member

This should be fixed in the latest release: https://github.com/timothycrosley/isort/releases/tag/4.3.16

Thanks!

~Timothy

timothycrosley added a commit that referenced this issue Mar 25, 2019
@timothycrosley
Merge pull request #912 from timothycrosley/feature/fix-issue-907
fa84e03 
Fix issue #907, adding minimal appdirs requirement version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timothycrosley @edmondsw