Update minimum pre-commit version to 2.9.2 #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR which led to 2.9.0 was made by a data scientist and so it contains a bug in the default types for `types_or`, it'd be better to have 2.9.2 as the minimum version - at least, that's what Anthony Sottile suggested be done in `black` psf/black#1875 (comment)
Codecov Report
@@ Coverage Diff @@
## main #1794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2942 2942
Branches 696 696
=========================================
Hits 2942 2942 |
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR which led to pre-commit 2.9.0 was made by a data scientist and so it contains a bug, it'd be better to have 2.9.2 as the minimum version - at least, that's what Anthony Sottile suggested be done in
blackpsf/black#1875 (comment)