Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run release workflows for upstream #2052

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 17, 2022

When pushing main on a fork, the release workflow triggers but, as expected, fails to deploy to PyPI because API tokens are missing from forks:

ERROR    HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/          
         Invalid or non-existent authentication information. See                
         https://pypi.org/help/#invalid-auth for more information.              

Before: https://github.com/hugovk/isort/actions/runs/3719681768/jobs/6308688909

Let's skip the release workflow for forks.

After: https://github.com/hugovk/isort/actions/runs/3719767321

Also, whilst the release drafter does work for forks, let's only run that for upstream too.

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #2052 (f501d7c) into main (6c83bcc) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2052   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          38       38           
  Lines        3084     3084           
  Branches      745      745           
=======================================
  Hits         3047     3047           
  Misses         26       26           
  Partials       11       11           

@timothycrosley timothycrosley merged commit 227c4ae into PyCQA:main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants