Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update line_length and single_line_exclusions in google profile #2149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jagapiou
Copy link

@jagapiou jagapiou commented Jun 29, 2023

Updated the google profile to match the style guide

@staticdev
Copy link
Collaborator

@jagapiou do you maybe have a link of those changes?

@jagapiou
Copy link
Author

jagapiou commented Jul 5, 2023

Line-length exemption for imports: https://google.github.io/styleguide/pyguide.html#32-line-length
Allowing multiple imports from collections.abc: https://google.github.io/styleguide/pyguide.html#313-imports-formatting

@jagapiou
Copy link
Author

jagapiou commented Jul 19, 2023

@staticdev just a ping on this in case it slipped your notifications. Anything else you need me to do?

isort/profiles.py Outdated Show resolved Hide resolved
@jagapiou jagapiou requested a review from dseomn September 29, 2023 09:01
@jagapiou jagapiou changed the title Update google profile Update single_line_exclusions in google profile Sep 29, 2023
@jagapiou jagapiou changed the title Update single_line_exclusions in google profile Update line_length and single_line_exclusions in google profile Sep 29, 2023
@staticdev
Copy link
Collaborator

Sorry for missing this @jagapiou . I see all checks are failing, we cannot merge like this.

@jagapiou
Copy link
Author

jagapiou commented Sep 29, 2023

No probs :-) I think those failures weren't my change, but the main it was based on. I've rebased, not sure how to run the checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants