Fix isort-action usage documentation #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtmckee
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
@DanielNoord This looks good. It aligns the isort docs with the isort-action implementation.
DanielNoord
approved these changes
Jan 10, 2025
|
It will need to be rebased though. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 39 39
Lines 3095 3095
Branches 787 787
=======================================
Hits 3068 3068
Misses 15 15
Partials 12 12 |
|
@DanielNoord--thanks for the review. This has been rebased & is ready to merge. |
|
See PyCQA/meta#64 (comment) I have stopped merging anything. |
kurtmckee
reviewed
Jan 11, 2025
staticdev
approved these changes
Jan 15, 2025
|
Thanks @jamescurtin @kurtmckee @DanielNoord |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix isort/isort-action#91
The current docs provide the wrong casing for the isort Github Action inputs.