Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom section support #275

Merged
merged 4 commits into from
Jul 13, 2015
Merged

Conversation

dpetzold
Copy link
Contributor

Users can now define their own sections and ordering. For example

import_heading_stdlib = Standard Library
import_heading_thirdparty = Third Party
import_heading_firstparty = First Party
import_heading_django = Django
import_heading_pandas = Pandas
known_django = django
known_pandas = pandas,numpy
known_first_party = p24,p24.imports._VERSION
sections = FUTURE,STDLIB,DJANGO,THIRDPARTY,PANDAS,FIRSTPARTY,LOCALFOLDER

would create two new sections with the specified known modules.

# Standard Library
import os
import p24.imports._argparse as argparse
import p24.imports._subprocess as subprocess
import sys

# Django
from django.conf import settings
from django.db import models

# Third Party
from bottle import Bottle, redirect, response, run

# Pandas
import numpy as np
import pandas as pd

# First Party
import p24.imports._VERSION as VERSION
import p24.shared.media_wiki_syntax as syntax

@dpetzold dpetzold force-pushed the custom-sections branch 5 times, most recently from 37dabee to 4dc6c5a Compare May 31, 2015 18:38
Derrick Petzold added 2 commits May 31, 2015 11:59
Users can now define their own sections and ordering. For example

    import_heading_stdlib = Standard Library
    import_heading_thirdparty = Third Party
    import_heading_firstparty = First Party
    import_heading_django = Django
    import_heading_pandas = Pandas
    known_django = django
    known_pandas = pandas,numpy
    known_first_party = p24,p24.imports._VERSION
    sections = FUTURE,STDLIB,DJANGO,THIRDPARTY,PANDAS,FIRSTPARTY,LOCALFOLDER

would create two new sections with the specified known modules.

    # Standard Library
    import os
    import p24.imports._argparse as argparse
    import p24.imports._subprocess as subprocess
    import sys

    # Django
    from django.conf import settings
    from django.db import models

    # Third Party
    from bottle import Bottle, redirect, response, run

    # Pandas
    import numpy as np
    import pandas as pd

    # First Party
    import p24.imports._VERSION as VERSION
    import p24.shared.media_wiki_syntax as syntax
@dpetzold
Copy link
Contributor Author

dpetzold commented Jun 1, 2015

Not sure how tests are passing in the other pr. natsort doesn't support python 2.6. Any ideas?

@dpetzold
Copy link
Contributor Author

natsort now has py2.6 compatibility

SethMMorton/natsort@fcda77a

I think the prs just to be rebuilt for them to pass.

@timothycrosley
Copy link
Member

Hi @dpetzold,

This looks great! Thanks for the improvement, will merge in for the next release :)

~Timothy

@timothycrosley timothycrosley merged commit e6ab665 into PyCQA:develop Jul 13, 2015
@timothycrosley
Copy link
Member

Merged here: #286 :)

@dpetzold
Copy link
Contributor Author

Thanks for letting me contribute! It was really a joy to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants