-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom section support #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpetzold
force-pushed
the
custom-sections
branch
5 times, most recently
from
May 31, 2015 18:38
37dabee
to
4dc6c5a
Compare
Users can now define their own sections and ordering. For example import_heading_stdlib = Standard Library import_heading_thirdparty = Third Party import_heading_firstparty = First Party import_heading_django = Django import_heading_pandas = Pandas known_django = django known_pandas = pandas,numpy known_first_party = p24,p24.imports._VERSION sections = FUTURE,STDLIB,DJANGO,THIRDPARTY,PANDAS,FIRSTPARTY,LOCALFOLDER would create two new sections with the specified known modules. # Standard Library import os import p24.imports._argparse as argparse import p24.imports._subprocess as subprocess import sys # Django from django.conf import settings from django.db import models # Third Party from bottle import Bottle, redirect, response, run # Pandas import numpy as np import pandas as pd # First Party import p24.imports._VERSION as VERSION import p24.shared.media_wiki_syntax as syntax
Not sure how tests are passing in the other pr. natsort doesn't support python 2.6. Any ideas? |
natsort now has py2.6 compatibility I think the prs just to be rebuilt for them to pass. |
Hi @dpetzold, This looks great! Thanks for the improvement, will merge in for the next release :) ~Timothy |
Merged here: #286 :) |
Thanks for letting me contribute! It was really a joy to work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now define their own sections and ordering. For example
would create two new sections with the specified known modules.