Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmm driver improvements #181

Merged

Conversation

Jasper-Harvey0
Copy link
Collaborator

Add delay option to DMM driver to help alleviate issues with Keithley DMM compatibility.
This stems from test script failures due to the Keithley sampling a measurement before the relays (or voltage rails etc) have completely settled. Apparently the Fluke is slower at this so it hasn't been a problem.

I also removed some dead code and formatted.

src/fixate/drivers/dmm/fluke_8846a.py Outdated Show resolved Hide resolved
src/fixate/drivers/dmm/fluke_8846a.py Outdated Show resolved Hide resolved
src/fixate/drivers/dmm/keithley_6500.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@clint-lawrence clint-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/fixate/drivers/dmm/keithley_6500.py Outdated Show resolved Hide resolved
src/fixate/drivers/dmm/helper.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@clint-lawrence clint-lawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't think this is the right big picture solution, it is our best pragmatic path forward right now. And the change itself looks good.

@clint-lawrence clint-lawrence merged commit d37cb5c into PyFixate:master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants