Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve api docs #207

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Improve api docs #207

merged 2 commits into from
Jul 31, 2024

Conversation

clint-lawrence
Copy link
Collaborator

Remove internals, add fixate._switching + a few other tweaks

Remove internals, add fixate._switching + a few other tweaks
@clint-lawrence
Copy link
Collaborator Author

@josh-marshall-amp @jcollins1983 My primary aim was to get the new jig switching api documented before creating a new release. I hope to do that as soon as this is merged.

I haven't been too pedantic, but quickly removed as much of the obviously non-public api details that were in the initial documentation build. I think overall it should make the docs much more usable

@josh-marshall-amp
Copy link
Contributor

for @jcollins1983 reference, the PRs get their auto-gen docs chucked up on readthedocs too. In this case it's the below, and you can always sub in the relevant PR

https://fixate--207.org.readthedocs.build

Copy link
Contributor

@josh-marshall-amp josh-marshall-amp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a few comments on docstring fix-ups

would be interesting (in future!) to check that, pre-commit style, any changed docstrings match a code-I-mean-docstring standard...

src/fixate/_switching.py Show resolved Hide resolved
src/fixate/_switching.py Show resolved Hide resolved
src/fixate/drivers/ftdi.py Outdated Show resolved Hide resolved
src/fixate/drivers/ftdi.py Outdated Show resolved Hide resolved
@clint-lawrence clint-lawrence merged commit d54dd19 into master Jul 31, 2024
10 checks passed
@clint-lawrence clint-lawrence deleted the switching-docs branch July 31, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants