Smartin data utils enhancement #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 5, 2023 15:40
…" which is RMS, not A like Asin(wt). RMS maked sense for this instrument type.
Untested as don't have a GPIB adapter here. Will ask a user to test this. Also couldn't help myself from converting .format() to f strings.
|
Can you see this? |
timlaracy
requested changes
Oct 17, 2023
added 2 commits
October 17, 2023 11:36
…h a spectrum analyzer on power level vs FFT of pure sine amplitude, A.
Changed scale factor to compute in RMS like a real SA instead of Sine amplitude A which is what an FFT reports.
timlaracy
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has some data utils enhancements but more importantly bug fixes in lab interfaces that need to get merged.