Remove escape() and escape_string() from MySQLdb. #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 83.99% 85.76% +1.77%
==========================================
Files 6 6
Lines 556 583 +27
==========================================
+ Hits 467 500 +33
+ Misses 89 83 -6
Continue to review full report at Codecov.
|
This was referenced Nov 18, 2021
Merged
1 task
|
why Remove escape() and escape_string() ? |
This was referenced Mar 7, 2022
This was referenced Mar 26, 2022
Closed
Same question. |
|
gnodar01
added a commit
to CellProfiler/CellProfiler
that referenced
this pull request
Feb 7, 2024
MySQLdb.escape_string was removed in v2.1.0, here: PyMySQL/mysqlclient#511 mysqlclient still allows escape_string to be used via the connection object really we should be using parameterized queries: https://pynative.com/python-mysql-execute-parameterized-query-using-prepared-statement/ that would require more substantial changes however
gnodar01
added a commit
to CellProfiler/CellProfiler
that referenced
this pull request
Feb 7, 2024
MySQLdb.escape_string was removed in v2.1.0, here: PyMySQL/mysqlclient#511 we can still access `escape_string` via the underlying `_mysql` object that mysqlclient wraps really we should be using parameterized queries: https://pynative.com/python-mysql-execute-parameterized-query-using-prepared-statement/ that would require more substantial changes however
gnodar01
added a commit
to CellProfiler/CellProfiler
that referenced
this pull request
Feb 7, 2024
MySQLdb.escape_string was removed in v2.1.0, here: PyMySQL/mysqlclient#511 mysqlclient still allows escape_string to be used via the connection object really we should be using parameterized queries: https://pynative.com/python-mysql-execute-parameterized-query-using-prepared-statement/ that would require more substantial changes however
gnodar01
added a commit
to CellProfiler/CellProfiler
that referenced
this pull request
Feb 7, 2024
MySQLdb.escape_string was removed in v2.1.0, here: PyMySQL/mysqlclient#511 we can still access `escape_string` via the underlying `_mysql` object that mysqlclient wraps really we should be using parameterized queries: https://pynative.com/python-mysql-execute-parameterized-query-using-prepared-statement/ that would require more substantial changes however
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.