Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building against Percona Server builds of MySQL client library libperconaserverclient #718

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

nattofriends
Copy link
Contributor

After #584, pkg-config is required.

I use Percona Server for MySQL, and use both the server as well as their client library. Percona Server for MySQL began shipping a .pc file in percona/percona-server#5215 Percona Server for MySQL 8.0.37, but the library name they ship is perconaserverclient:

$ pkg-config --exists perconaserverclient
$ echo $?
0
$ pkg-config --cflags perconaserverclient
-I/usr/include/mysql
$ pkg-config --libs perconaserverclient
-lperconaserverclient

This PR adds support for that name to pkg-config invocations.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (e2a908b) to head (0571d0a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files           7        7           
  Lines         548      548           
=======================================
  Hits          487      487           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@methane methane merged commit 423e45e into PyMySQL:main Aug 7, 2024
6 of 11 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants