Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression relating to repository url in maturin upload when upgrading to 1.7.2 #2228

Closed
1 task
seddonym opened this issue Sep 25, 2024 · 2 comments · Fixed by #2229
Closed
1 task

Regression relating to repository url in maturin upload when upgrading to 1.7.2 #2228

seddonym opened this issue Sep 25, 2024 · 2 comments · Fixed by #2229
Labels
bug Something isn't working

Comments

@seddonym
Copy link

seddonym commented Sep 25, 2024 •
edited
Loading

Bug Description

We use maturin upload via the Maturin action Github action.

Our latest release failed, apparently due to a malformed repository url:

💥 maturin failed
  Caused by: 💥 Failed to upload "rustfluent-0.1.0a3-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl" (384.1 KB)
  Caused by: Failed to upload the wheel with status 400: <html>
 <head>
  <title>[40](https://github.com/kraken-tech/python-rustfluent/actions/runs/11029344761/job/30632470084#step:3:43)0 Bad Request</title>
 </head>
 <body>
  <h1>400 Bad Request</h1>
  The server could not comply with the request since it is either malformed or otherwise incorrect.<br/><br/>
POST body may not contain duplicate keys (URL: &#x27;https://upload.pypi.org/legacy&#x27;)

Downgrading to maturin 1.7.1 fixed the issue.

I'm guessing this is related to this change to the repository URLs, introduced in Maturin 1.7.2.

Your maturin version (maturin --version)

1.7.2

Your Python version (python -V)

Unknown

Your pip version (pip -V)

Unknown

What bindings you're using

pyo3

Does cargo build work?

n/a

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

I'm not sure, but you can see the full error happening in this github action run: https://github.com/kraken-tech/python-rustfluent/actions/runs/11029344761/job/30632470084
@seddonym seddonym added the bug Something isn't working label Sep 25, 2024
@seddonym seddonym mentioned this issue Sep 25, 2024
Closed
@messense
Copy link
Member

Maybe it's that change, will try to reproduce this issue later.

See also pypi/warehouse#16756

@messense messense mentioned this issue Sep 25, 2024
Merged
@seddonym
Copy link
Author

Thanks for the lightning-fast fix! Our releases are now working again, using maturin 1.7.3. 👏🏻

anuradhawick added a commit to anuradhawick/kmertools that referenced this issue Sep 26, 2024
@anuradhawick
REL: Bump package versions to 0.1.4
c97b62d 
Had to do this because PyO3/maturin#2228 #2228 somehow failed pypi uploads. Now the release should be able to go through
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pypi/testpypi upload messense/maturin
2 participants
@seddonym @messense